-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commercial support, fix WASM and issues with Qt 6.7.+ #272
base: master
Are you sure you want to change the base?
Conversation
… as host and 'wasm' as target
@Kidev const isAutodesktopSupported = async (): Promise<boolean> => {
const rawOutput = await getPythonOutput("aqt", ["version"]);
const match = rawOutput.match(/aqtinstall\(aqt\)\s+v(\d+\.\d+\.\d+)/);
return match ? compareVersions(match[1], ">=", "3.0.0") : false;
}; The problem is, if you point Right now as you discovered, one either needs to pass |
Indeed, I'll remove it from the README and such then. In the meantime I got it all working, as you can see in this workflow file of a project of mine. You can check the latest run here. You can use it right now if you need to, no need to wait for either PRs: - name: Install Qt for host architecture
uses: Kidev/[email protected]
with:
version: '6.8.1'
host: 'all_os'
target: 'wasm'
arch: 'wasm_singlethread'
set-env: 'true'
modules: 'qtquick3d'
aqtsource: 'git+https://github.com/Kidev/aqtinstall.git@wasm'
extra: '--autodesktop' |
@Kidev My application depends on Qt Quick, and this doesn't seem to properly install it for WASM or Android.
Here's my config:
Why is Quick not getting installed? Actually, scrolling up, it can't find Qt core...
...because it can't find Qt6CoreTools.
|
Nevermind, I had the wrong host paths set in my configure command. |
The PR fixing WASM and more was merged into master and aqtinstall will soon release its version 3.2.0 including those changes. For it to work, I updated the default value of Note Until the release 3.2.0 of
Note Once the release 3.2.0 of
|
https://github.com/miurahr/aqtinstall/blob/master/pyproject.toml#L29 |
BTW: I have PR #267 Open for the |
It is a good idea, I also have updated it in my latest update, along with py7zr. It is not yet ready for this PR, still need some testing, but I'm working on getting commercial versions available to the installation using this Action (miurahr/aqtinstall#878 https://github.com/Kidev/install-qt-action). Here you can see a successful install of Qt using the |
Added working support for Qt commercial. You can see an example using my version of the workflow You can use it right now yourself like this, until this PR is merged: - name: Install Qt
uses: Kidev/[email protected]
with:
version: '6.8.1'
target: 'desktop'
arch: 'linux_gcc_64'
aqtsource: 'git+https://github.com/miurahr/aqtinstall'
use-commercial: true
user: ${{ secrets.QT_USERNAME }}
password: ${{ secrets.QT_PASSWORD }}
modules: 'qtquick3d' |
Fixed the issue after the re-sync, and some force push shenanigans to run the workflows on my repo too |
Update: @jurplel almost all tests pass on my repo. There are issues with the The commercial PR can be found here for more info. Caution The docs and some commands have changed, I'll update this soon, along with some tests |
@Kidev Will you be changing the YAML syntax (input parameter name) e.g. from Perhaps it's worth finalizing the YAML syntax now (even if it's still passing the old argument names to aqtinstall, since the renames haven't been released yet), or marking this as a draft if you'd rather wait for the next aqtinstall release, so there's no concern with the YAML backwards compatibility. |
That is a nice idea indeed, I would not have done that. I'm doing it right now along with the changes in commands to aqtinstall, been quite busy the last 2 weeks or so |
This sounds good to me—after CI is passing (which I believe it should do if you merge/rebase off of main), we should be good to merge this, then merge @jdpurcell's ARM64 hosts PR |
This should be good, I'm testing on my repo as usual. Same as last time, it works on the official repo since my PR on aqtinstall was merged, BUT it is NOT YET RELEASED in a version. So adding this is required until it is the case: aqtsource: 'git+https://github.com/miurahr/aqtinstall.git@master' |
email: '****@gmail.com' | ||
pw: '****' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kidev Or perhaps (to prevent any unfortunate mistakes 😅):
email: '****@gmail.com' | |
pw: '****' | |
email: ${{ secrets.QT_EMAIL }} | |
pw: ${{ secrets.QT_PW }} |
- name: Install Qt | ||
uses: jurplel/install-qt-action@v4 | ||
with: | ||
version: '5.15.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this bit of docs with new default settings
I think we can merge soon but hold off on releasing this until the new aqtinstall version drops. I wish we had a way to test this, but I guess since it is a commercial version, there is not really an easy way since we need credentials... |
This PR includes
aqtinstall
versions, making the action once again able to install any version of Qt, WASM and extensions includedContext
Since Qt 6.7+, the Qt team decided to make WASM a part of
all_os
as host, with targetwasm
. This is sensible as the WASM version of Qt cannot work on its own and needs a host. To install Qt WASM for the latest versions, it is now required to use the action like this:This change is required by the latest versions of
aqtinstall
(3.2.*)Working examples: